Skip to content

FIX: Sync enable/disable system mouse dynamically. #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

FIX: Sync enable/disable system mouse dynamically. #1639

wants to merge 2 commits into from

Conversation

@jimon
Copy link
Contributor

@jimon jimon commented Feb 13, 2023

Description

Continuing #1119

@jimon
Copy link
Contributor Author

jimon commented Feb 13, 2023

@andrew-oc do you remember if we found any issues with position vs anchoredPosition?

@jimon jimon mentioned this pull request Feb 13, 2023
Closed
jfreire-unity
jfreire-unity approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@jfreire-unity jfreire-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jimon jimon force-pushed the dmytro/merging-1119 branch from d8daf79 to 4fb1a84 Compare February 14, 2023 12:55
@unity-cla-assistant
Copy link

unity-cla-assistant commented Jul 6, 2023 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ekcoh
❌ Dmytro Ivanov

Dmytro Ivanov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-github-com
Copy link

codecov-github-com bot commented Oct 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...system/InputSystem/Plugins/UI/VirtualMouseInput.cs 10.52% 17 Missing ⚠️ 
@@             Coverage Diff             @@
##           develop    #1639      +/-   ##
===========================================
- Coverage    76.70%   76.62%   -0.09%     
===========================================
  Files          465      472       +7     
  Lines        87919    88293     +374     
===========================================
+ Hits         67442    67654     +212     
- Misses       20477    20639     +162
Flag Coverage Δ
inputsystem_MacOS_2021.3 5.90% <ø> (-0.01%) ⬇️
inputsystem_MacOS_2022.3 5.37% <ø> (-0.01%) ⬇️
inputsystem_MacOS_2022.3_project 74.35% <10.52%> (-0.24%) ⬇️
inputsystem_MacOS_6000.0 5.18% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.0_project 76.26% <10.52%> (-0.24%) ⬇️
inputsystem_MacOS_6000.2 5.18% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.2_project 76.26% <10.52%> (-0.24%) ⬇️
inputsystem_MacOS_6000.3 5.18% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.3_project 76.26% <10.52%> (-0.24%) ⬇️
inputsystem_MacOS_6000.4 5.18% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.4_project 76.26% <10.52%> (-0.24%) ⬇️
inputsystem_Ubuntu_2021.3 5.91% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_2022.3 5.37% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_2022.3_project 74.16% <10.52%> (-0.24%) ⬇️
inputsystem_Ubuntu_6000.0 5.19% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0_project 76.08% <10.52%> (-0.24%) ⬇️
inputsystem_Ubuntu_6000.2 5.19% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.2_project 76.08% <10.52%> (-0.24%) ⬇️
inputsystem_Ubuntu_6000.3 5.19% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3_project 76.08% <10.52%> (-0.24%) ⬇️
inputsystem_Ubuntu_6000.4 5.19% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.4_project 76.08% <10.52%> (-0.24%) ⬇️
inputsystem_Windows_2021.3 5.90% <ø> (-0.01%) ⬇️
inputsystem_Windows_2022.3 5.37% <ø> (-0.01%) ⬇️
inputsystem_Windows_2022.3_project 74.49% <10.52%> (-0.24%) ⬇️
inputsystem_Windows_6000.0 5.18% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.0_project 76.40% <10.52%> (-0.24%) ⬇️
inputsystem_Windows_6000.2 5.18% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.2_project 76.40% <10.52%> (-0.24%) ⬇️
inputsystem_Windows_6000.3 5.18% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3_project 76.41% <10.52%> (-0.24%) ⬇️
inputsystem_Windows_6000.4 5.18% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.4_project 76.40% <10.52%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...system/InputSystem/Plugins/UI/VirtualMouseInput.cs 64.23% <10.52%> (-3.73%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfreire-unity jfreire-unity jfreire-unity approved these changes

@andrew-oc andrew-oc Awaiting requested review from andrew-oc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jimon @unity-cla-assistant @jfreire-unity @ekcoh